On Sat, 01 Oct 2005 14:24:12 -0400 Mark Lord wrote: > Jeff Garzik wrote: > .. > > Ah hah! I found the other SCSI suspend patch: > > http://lwn.net/Articles/97453/ > > Anybody (Joshua?) up for reconciling and testing the two? > > I just now tried out *only* "the other SCSI suspend patch", > and by itself it hangs on resume. Laptop computer, blank screen, > no serial ports, no printk()s visible. > > And there's one minor bug in that patch: it uses GFP_KERNEL to > alloc a buffer, but on resume it really should use GFP_ATOMIC instead, > since the swap device is the same drive we're trying to resume.. > > > 2) sd should call START STOP UNIT on resume > > That's probably why it hangs when used as-is by itself. > I may do some further testing. > > Anyone else out there playing with this yet? Not playing with it yet, just making some changes as suggested by Jeff and Christoph. Patches are in http://www.xenotime.net/linux/scsi/ 1. http://www.xenotime.net/linux/scsi/scsi-suspend-resume.patch 2. http://www.xenotime.net/linux/scsi/scsi-susres-startstop2.patch and work-in-progress: adding <spindown> ok/allowed to scsi targets: http://www.xenotime.net/linux/scsi/scsi-susres-stst-spin.patch (this patch file includes 1. and 2. above) --- ~Randy - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
