On Thu, Sep 29, 2005 at 08:34:37AM +0100, Christoph Hellwig wrote: > is an ULDD operation, not an LLDD one, and this fits the layering model > much better. The only complaints here are cosmetics: > > - generic_scsi_suspend/generic_scsi_resume are misnamed, they should > probably be scsi_device_suspend/resume. > - while we're at it they could probably move to scsi_sysfs.c to keep > them static in one file - they're just a tiny bit of glue anyway. > - get rid of all the CONFIG_PM ifdefs - it just clutters thing up far > too much. Actually one important thing is missing, that is a way to avoid spinning down external disks. As a start a sysfs-controlable flag should do it, later we can add transport-specific ways to find out whether a device is external. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
