Douglas Gilbert wrote:
Jeff,
This is a retransmission (and resync against lk 2.6.14-rc1)
of a patch that I sent on 2005/8/28 . I haven't seen a reply.
If it has be applied, then my following patch
("[PATCH] libata: ATA Information VPD page, lk 2.6.14-rc1")
should apply.
This patch adds more general error processing, typically for
problems (or an early finish) detected while a
SCSI command is being processed prior to an ATA
command being executed.
Changelog:
- add extern ata_scsi_set_sense() to build SCSI
sense data and corresponding status
- this allows removal of extern ata_scsi_badcmd()
and static inline ata_bad_scsiop() and ata_bad_cdb()
- change "xlat" functions in libata-scsi so they
are responsible for SCSI status and sense data
when they return 1. This allows GOOD status or a
specialized error to be set.
- set DRIVER_SENSE when SAM_STAT_CHECK_CONDITION
is flagged in scsi_cmnd::result
- yield an error for mode sense requests for saved
values [sat-r05]
- change recent rw_zero_length patch to do nothing
(yield GOOD status) when transfer_length==0 for
10 and 16 byte READ and WRITE commands (SBC-2).
Hi Doug,
In March I got a bunch of patches in this same area into libata-dev; I'm
not sure where they sit now (definitely not in 2.6.14-rc). Jeff would
probably know.
See start of thread:
http://lkml.org/lkml/2005/3/17/157
So there would be conflicts if my stuff went forward--a lot of the
changes are similar. I think the best bet would be to find the tree
with my patches and for you to look at it and find problems that you
solved in this patch that I didn't address.
BR
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
