From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] sez: >> - >> + if (scsicmd->request->rq_disk) >> + strlcpy(fsa_dev_ptr[cid].devname, >> + scsicmd->request->rq_disk->disk_name, >> + min(sizeof(fsa_dev_ptr[cid].devname), >> + sizeof(scsicmd->request->rq_disk->disk_name) + 1)); > >do we really need this? A driver really shouldn't look at ->rq_disk This is not changing the code, it is in all versions of the driver. It is merely replacing a constant (8) with a sizeof operator. This code is in support of an existing ioctl used by the management software to track the naming of the devices. Removing this will break the management software. -- Mark - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
