On Mon, Sep 19, 2005 at 04:53:13PM +0200, Andreas Herrmann wrote: > > > @@ -68,6 +68,8 @@ ZFCP_DEFINE_ADAPTER_ATTR(s_id, "0x%06x\n > > > ZFCP_DEFINE_ADAPTER_ATTR(peer_wwnn, "0x%016llx\n", > adapter->peer_wwnn); > > > ZFCP_DEFINE_ADAPTER_ATTR(peer_wwpn, "0x%016llx\n", > adapter->peer_wwpn); > > > ZFCP_DEFINE_ADAPTER_ATTR(peer_d_id, "0x%06x\n", adapter->peer_d_id); > > > +ZFCP_DEFINE_ADAPTER_ATTR(physical_wwpn, "0x%016llx\n", > adapter->physical_wwpn); > > > this information belongs into the transport class, not the driver. > > What's the peer information above? is that for point-to-point FC > > connections? > > Hope it is acceptable to keep this attributes in zfcp sysfs subtree > until I will send a patch to add physical port_name and physical > port_id information to the transport class. keeping the peer stuff is okay for now, adding the physical attributes is not, they should be moved to the transport class from the start. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
