Yes, agreed. I believe that code was ported from 2.4 driver where the error handler expected DID_RESET status. -----Original Message----- From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Christoph Hellwig Sent: Monday, September 19, 2005 1:04 PM To: Andrew Vasquez Cc: linux-scsi@xxxxxxxxxxxxxxx Subject: Re: eh_active checks in qla2xxx error handling On Tue, Sep 06, 2005 at 02:20:28PM +0200, Christoph Hellwig wrote: > qla2xxx is the only driver looking at eh_active, and doing the wait > for oustanding commands only from EH thread resets but not from the > ioctls looks rather wrong to me. Do you remember the rational for it? ping? - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
