Re: [PATCH] fix retries and command completion when using REQ_BLOCK_PC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mike Christie wrote:
Hi Jens and James,

As you know a side effect of SCSI using REQ_BLOCK_PC is that commands
that used to originate from SCSI do not obey the retries value, and we
now add extra processing of failures in scsi_io_completion.

The patch below adds a retry count on the request which is used like the
timeout value. And it changes scsi_generic_done to always complete the
entire command which emulates the old behavior we had with
scsi_wait_req/scsi_do_req where scsi_io_completeion does not process the
error and request additional retries.


Oh yeah this is also what sd does with REQ_BLOCK_PC commands and with my other patch for st in this mail http://marc.theaimsgroup.com/?l=linux-scsi&m=112708046601499&w=2 it is what tape will do.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux