On Tue, Sep 13, 2005 at 09:51:16PM +0200, Andreas Herrmann wrote: > From: Maxim Shchetynin <maxim@xxxxxxxxxx> > > zfcp: provide support for NPIV > > N_Port ID Virtualization (NPIV) allows a single FCP port to appear as > multiple, distinct ports providing separate port identification. NPIV > is supported by FC HBAs on System z9. zfcp was adapted to support this > new feature. I have a hard time understanding much of the driver and thus this patch aswell, but it looks like you're adding the luns using scsi_add_device instead of using the proper midlayer lun scan. > @@ -68,6 +68,8 @@ ZFCP_DEFINE_ADAPTER_ATTR(s_id, "0x%06x\n > ZFCP_DEFINE_ADAPTER_ATTR(peer_wwnn, "0x%016llx\n", adapter->peer_wwnn); > ZFCP_DEFINE_ADAPTER_ATTR(peer_wwpn, "0x%016llx\n", adapter->peer_wwpn); > ZFCP_DEFINE_ADAPTER_ATTR(peer_d_id, "0x%06x\n", adapter->peer_d_id); > +ZFCP_DEFINE_ADAPTER_ATTR(physical_wwpn, "0x%016llx\n", adapter->physical_wwpn); this information belongs into the transport class, not the driver. What's the peer information above? is that for point-to-point FC connections? > ZFCP_DEFINE_ADAPTER_ATTR(fc_link_speed, "%d Gb/s\n", adapter->fc_link_speed); dito this one belongs only in the transport class. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html