Re: Fw: legacy megaraid driver bug in mm-series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>>This looks preyyu much like a breakage because we're now always sending
>>>>>S/G list down the scsi layer.
>>>>>
>>>>>The patch below brings over code to handle that case from the megaraid_mbox
>>>>>driver.  It's still wrong for the case someone sends a MODE_SENSE from
>>>>>highmem userspace, but it should at least boot with the patch applied.
>>>>>
>>>>
>>>>
>>>>Jack, have you had a chance to test this?
>>>>
>>>>Thanks.
>>>>
>>>
>>>Sorry, I spent the weekend whitewater rafting :)  I will be able to test
>>>this patch on Wednesday. Which kernel versions should I apply this patch to?
>>
>>
>>I did it against the at that time latest scsi-misc tree.  The old megaraid
>>driver hasn'tt changed much for a long time so it should apply against
>>any recent-ish tree.
>>
>>
> 
> 
> I tried the patch on a 2.6.13-mm1 tree. It applied cleanly, but produced
> a few compiler warnings:
> 
> 
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c: In function `issue_scb':
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1143: warning: passing
> arg 2 of `writel' makes pointer from integer without a cast
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c: In function
> `issue_scb_block':
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1206: warning: passing
> arg 2 of `writel' makes pointer from integer without a cast
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1219: warning: passing
> arg 2 of `writel' makes pointer from integer without a cast
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1221: warning: passing
> arg 1 of `readl' makes pointer from integer without a cast
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c: In function
> `megaraid_isr_memmapped':
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1351: warning: passing
> arg 1 of `readl' makes pointer from integer without a cast
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1358: warning: passing
> arg 2 of `writel' makes pointer from integer without a cast
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1377: warning: passing
> arg 2 of `writel' makes pointer from integer without a cast
> /usr/src/linux-2.6.13-mm1/drivers/scsi/megaraid.c:1381: warning: passing
> arg 1 of `readl' makes pointer from integer without a cast
> 
> Booting the kernel resulted in the same symptoms as before (can not
> mount root fs).
> 

I have also tested the 2-6-14-rc1 and I have the same bug.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux