Re: [PATCH 1/2] fix EH thread teardown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 13, 2005 at 03:03:19PM -0400, Alan Stern wrote:
> On Tue, 13 Sep 2005, Rolf Eike Beer wrote:
> 
> > Looks like someone has to build a waitqueue to fix this.
> 
> Tell me what you think of this patch.  I'm not sure whether that 
> condition, host_busy == host_failed, is correct for the call to 
> wait_event_interruptible.

I don't think we even need the waitque, a wake_up_process can replace
it when there's only a single process waiting on it ever.  Similarly
we don't need eh_alive - EH must be alive after scsi_add_host returned,
and no command may be in flight before that.

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux