> -----Original Message----- > From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] > Sent: Tuesday, September 13, 2005 10:49 AM > To: Timothy Thelin > Cc: James Bottomley; SCSI Mailing List; Linux Kernel; Andrew Morton > Subject: Re: [PATCH 2.6.13] scsi: sd fails to copy cmd_len on SG_IO > > > Timothy Thelin wrote: > > This fixes an issue when doing SG_IO on an sd device: the > > sd driver fails to copy the request's cmd_len to the scsi > > command's cmd_len when initializing the command. > > > > Do you need the same fix to st, sr, and scsi_lib (in the > scsi_generic_done path)? > I just looked, and st and sr look like they need the same fix, but i'm unaware of where scsi_lib might need it (I'm new to the Linux scsi stack). Mind elaborating on your thoughts of the scsi_generic_done path? (I cant find the symbol in drivers/scsi/*) > > Signed-off-by: Timothy Thelin <timothy.thelin@xxxxxxx> > > > > --- linux-2.6.13.orig/drivers/scsi/sd.c 2005-08-28 > 16:41:01.000000000 -0700 > > +++ linux-2.6.13/drivers/scsi/sd.c 2005-09-13 > 09:39:06.000000000 -0700 > > @@ -236,6 +236,7 @@ static int sd_init_command(struct scsi_c > > return 0; > > > > memcpy(SCpnt->cmnd, rq->cmd, sizeof(SCpnt->cmnd)); > > + SCpnt->cmd_len = rq->cmd_len; > > if (rq_data_dir(rq) == WRITE) > > SCpnt->sc_data_direction = DMA_TO_DEVICE; > > else if (rq->data_len) > > - > > : send the line "unsubscribe > linux-scsi" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
