On Mon, Sep 12, 2005 at 10:05:55AM -0400, Salyzyn, Mark wrote: > Mark Salyzyn writes: > >Christoph Hellwig writes: > >>> + aac_driver_template.name = aac_drivers[index].name; > >>this is broken. it overwrites the name every time a host is allocated. > >Especially it does this on a live template. Just implemented ->info > > > >->info() is not enough, there are places in the scsi subsystem which do > >not implement the info override over top the template name. > > > >I had discussed the possibility of submitting a patch to the scsi > subsystem to fix that brokenness, I am generally concerned with legacy > issues. > > Looks like few remain. Could not figure a way to alter scsi_module.c > that made sense, doable but expensive, but hosts.c could be fixed up > with: Ok. Long-term I'll probably just kill ->name. Note that all these are error messages that don't happen unless someone broke the actual driver, so adding the branding string there doesn't seem to be very interesting.. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
