Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] writes: >> @@ -929,9 +932,14 @@ >> printk(KERN_INFO "Adaptec %s driver (%s)\n", >> AAC_DRIVERNAME, aac_driver_version); >> >> - error = pci_module_init(&aac_pci_driver); >> - if (error) >> + error = pci_register_driver(&aac_pci_driver); >> + if (error < 0 || list_empty(&aac_devices)) { >> + if (error >= 0) { >> + pci_unregister_driver(&aac_pci_driver); >> + error = -ENODEV; >> + } >> return error; >The list_empty check is wrong. I driver should stay loaded even if no devices have been found. We get complains about a driver module loaded with no associated hardware. There are system configurations that probe for installed hardware by loading modules, they expect only the functional driver modules to load. What purpose is there in a driver module that is loaded with no hardware? Sincerely -- Mark Salyzyn - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
