Luben Tuikov wrote: > Signed-off-by: Luben Tuikov <luben_tuikov@xxxxxxxxxxx> <snip> An interesting document. I have a small quibble here (and a larger one about the SMP user space access that I will elaborate on in a day or so). > +Port events, passed on a _phy_: > + PORTE_BYTES_DMAED, (M) > + PORTE_BROADCAST_RCVD, (E) > + PORTE_LINK_RESET_ERR, (C) > + PORTE_TIMER_EVENT, (C) > + PORTE_HARD_RESET. Link layer broadcasts don't only come from expanders (i.e. BROADCAST(CHANGE) ); SAS 1.1 (sas1r09e.pdf) defines BROADCAST(SES) coming from a target port associated with an enclosure device (SES peripheral type). It is not clear to me how the associated primitive is conveyed back with the broadcast. If it is not conveyed back then perhaps that broadcast define could be expanded to: PORTE_BROADCAST_CHANGE (E) PORTE_BROADCAST_SES (Target) and a note inserted that BROADCAST(RESERVED CHANGE 0) and BROADCAST(RESERVED CHANGE 1) be mapped to PORTE_BROADCAST_CHANGE by the LLDD as per table 79 of sas1r09e.pdf . BTW table 70 indicates an initiator can originate a BROADCAST(CHANGE), not just an expander. Doug Gilbert - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html