Re: [PATCH 5/8] aacraid: error return checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> @@ -929,9 +932,14 @@
>  	printk(KERN_INFO "Adaptec %s driver (%s)\n",
>  	  AAC_DRIVERNAME, aac_driver_version);
>  
> -	error = pci_module_init(&aac_pci_driver);
> -	if (error)
> +	error = pci_register_driver(&aac_pci_driver);
> +	if (error < 0 || list_empty(&aac_devices)) {
> +		if (error >= 0) {
> +			pci_unregister_driver(&aac_pci_driver);
> +			error = -ENODEV;
> +		}
>  		return error;

The list_empty check is wrong.  I driver should stay loaded even if
no devices have been found.

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux