On Thu, 2005-09-08 at 13:50 -0700, Mark Haverkamp wrote: > device_config_needed = CHANGE; > + scsi_add_device(dev->scsi_host_ptr, > + device->channel, device->id, > + device->lun); Well ... this is actually wrong: scsi_add_device() returns an sdev on success with the refcount bumped up for you. If you don't do a put, you'll be stuck with a device you can't get rid of. However, all other users of scsi_add_device() make the same mistake ... I'll apply this patch and fix the API to return zero or error and not bump the sdev refcount. James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html