On 09/09/05 16:05, Nish Aravamudan wrote: > On 9/9/05, Luben Tuikov <luben_tuikov@xxxxxxxxxxx> wrote: > >>Signed-off-by: Luben Tuikov <luben_tuikov@xxxxxxxxxxx> > > > <snip> > > >>--- linux-2.6.13-orig/drivers/scsi/sas-class/sas_expander.c 1969-12-31 19:00:00.000000000 -0500 >>+++ linux-2.6.13/drivers/scsi/sas-class/sas_expander.c 2005-09-09 11:14:29.000000000 -0400 > > > <snip> > > +static int sas_ex_general(struct domain_device *dev) > > <snip> > > + set_current_state(TASK_INTERRUPTIBLE); > + schedule_timeout(5*HZ); > > Can you use msleep_interruptible() here? I don't see wait-queues in > the immediate vicinity. If not, and you're going for the normal -mm > route (and from there to mainline), can you use > schedule_timeout_interruptible(), please? Yes, sure. I don't see why not. Luben - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
