James Bottomley wrote:
On Thu, 2005-09-08 at 14:23 -0500, Mike Christie wrote:
I think the reason it was a dependency was becuase the transport class
manages does the lifetime management/refcounting for the
initiators/iscsi_tcp.c session struct. scsi_transport_iscsi allocates
the scsi_host, and the initiator/iscsi_tcp.c's session structure is
allocated in that host_data.
Yes, but Kconfig isn't about lifetimes or, in fact, much of the way the
code is constructed; it's about how the user selects particular
features.
In the current setup, they have to know to say Y/M to the ISCSI
attribute question even to see the config option for the iscsi
initiator. This is a bit counter intuitive (and definitely isn't the
way any of the other drivers that depend on transport classes are
presented).
Yeah, sorry about that. With the userspace split and interpreting and
implementing the review comments everything got a bit mixed up and we
ended up the using the classes in a strange way. Should we resplit
things up so that the host_alloc code is not part of the transport
class? I think this will help the ql4xxx guys, Andrew have you started that?
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
