Adaptec DPT call schedule_timeout with irq off

[Dave Jiang <djiang@xxxxxxxxxx>]

I noticed that in the Adaptec DPT driver, drivers/scsi/dpt_i2o.c in 
funciton adapt_i2o_post_wait() around line 1161ish. spin_lock_irqsave() 
is called. However then spin_unlock() is called 2 lines later and 
leaving IRQ disabled. Then a little bit later, schedule_timeout() is 
called with IRQ off. Isn't that bad? Why was irq left off earlier 
instead of doing spin_unlock_irqrestore()? Am I missing something.....

Please cc me on replies. Thank you!

--
Dave

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html