On Wed, Aug 24, 2005 at 02:13:48PM -0700, Andrew Vasquez wrote:
> /proc support has been stripped from the qla2xxx driver. So,
> hostt->present is never incremented:
>
> void scsi_proc_hostdir_add(struct scsi_host_template *sht)
> {
> if (!sht->proc_info)
> return;
>
> down(&global_host_template_sem);
> if (!sht->present++) {
> ...
>
> SCSI_IOCTL_PROBE_HOST returns hostt->present:
>
> static int ioctl_probe(struct Scsi_Host *host, void __user *buffer)
> {
> unsigned int len, slen;
> const char *string;
> int temp = host->hostt->present;
>
> ...
> return temp;
>
> Not sure how we want to fix it, perhaps for backwards compatibility,
> increment present regardless of the value of proc_info.
>
> Something like this, perhaps (untested)?
No, please not. Just remove the ->present check in the ioctl, with
the hotplug mode in place we should consider an host always probed
for this legacy.
And while we're at it we should add deprecation warnings for most of
the crufy ioctls in scsi_ioctl.c..
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
