On Mon, 2005-08-22 at 09:28 -0500, James Bottomley wrote: > > I think providing locking inside idr.c was always a mistake - generally we > > rely on caller-provided locking for such things. > > Well, the reason is because they wanted lockless pre-alloc. If you do > it locked, you can't use GFP_KERNEL for the memory allocation flag which > rather defeats its purpose. It looks to be feasible to implement this locklessly the same way as the radix-tree does (with a per_cpu list), except that you still need a start/end API for the pre allocation to do the initial disable of pre- emption. Then the remove should simply then free the entry (again like radix- tree) and let the slab take care of necessary locking. Of course, if we're going to go to all this trouble, the next question that arises naturally is why not just reuse the radix-tree code to implement idr anyway ... ? James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
