Christoph Hellwig wrote: >On Tue, Aug 16, 2005 at 11:11:06AM +0200, Rolf Eike Beer wrote: >> cpqfcTS_reset() is never referenced from anywhere. By using the >> nonexistent constant SCSI_RESET_ERROR it causes just another unneeded >> compile error. > >That was the old reset handler. Do you actually have this hardware? >The driver is pretty much un-recoverable and mkp is working on a from >scratch driver for this hardware - I don't think putting any work into the >driver makes sense unless you have a very urgent need to use it. No, I don't have (but maybe I'll get access to it soon). There was a request on lkml last week for a working version of this driver. For the moment I try to clean this up a bit before doing some real work. I found 4 major things that should be done, for half of them I have patches in a proof-of-concept state. -split the interrupt handler into a handler and a tasklet -remove the stack abuse -use Linux 2.6 hardware probing code (this would cause the most problems for me, I'm not familiar with the preferred way of doing this for scsi drivers) -fix kernel thread stopping After this some more error checking at different places can't hurt. And a big Lindent run. Eike
Attachment:
pgpnaiycmDBPz.pgp
Description: PGP signature
