Re: [-mm PATCH 29/32] drivers/scsi: fix-up schedule_timeout() usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/15/2005 02:27:51 PM, Nishanth Aravamudan wrote:
> Description: Use schedule_timeout_uninterruptible() instead of
> set_current_state()/schedule_timeout() to reduce kernel size.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>
> 
> ---
> 
>  drivers/scsi/osst.c           |    9 +++------
>
> diff -urpN 2.6.13-rc5-mm1/drivers/scsi/osst.c
> 2.6.13-rc5-mm1-dev/drivers/scsi/osst.c
> --- 2.6.13-rc5-mm1/drivers/scsi/osst.c	2005-08-07 10:05:21.000000000
> -0700
> +++ 2.6.13-rc5-mm1-dev/drivers/scsi/osst.c	2005-08-12
> 13:42:13.000000000 -0700
> @@ -862,8 +862,7 @@ static int osst_recover_wait_frame(struc
>  				retval = osst_write_error_recovery(STp,
> aSRpnt, 0);
>  				break;
>  			}
> -			set_current_state(TASK_INTERRUPTIBLE);
> -			schedule_timeout (HZ / OSST_POLL_PER_SEC);
> +			schedule_timeout_interruptible(HZ /
OSST_POLL_PER_SEC);

Others have suggested using msleep in osst instead of schedule, which I think
is 
more appropriate.

Regards, Willem Riede.



-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux