RE: [PATCH] shorten workqueue name length

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Any history on why the limit exists ?

-- james s

> -----Original Message-----
> From: linux-scsi-owner@xxxxxxxxxxxxxxx
> [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx]On Behalf Of 
> Christoph Hellwig
> Sent: Tuesday, August 09, 2005 12:32 PM
> To: Smart, James
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] shorten workqueue name length
> 
> 
> On Tue, Aug 09, 2005 at 12:07:12PM -0400, 
> James.Smart@xxxxxxxxxx wrote:
> > A customer passed this fix to me...
> > 
> > In a system with double-digit adapter counts, after a few
> > rmmod/insmod attempts, the system oops. It always occurs when
> > the scsi host number reaches 100.
> > 
> > What is happening is that scsi_add_host() detects a transport that
> > needs to allocate a workqueue, thus calls 
> create_singlethread_workqueue().
> > It hits a BUG_ON() in kernel/workqueue.c:__create_workqueue() which
> > ensures the length of the name for the workqueue is 10 
> characters or less.
> > As the name is "scsi_wq_100", we have exceeded the 10 character max.
> > 
> > I assume there's good reason for the name to be 10 or less. 
> So what I've
> > done is shorten the name for the workqueue. Should work 
> until the host number
> > reaches 10000.
> 
> I'd suggest just killing that limit in workqueue.c
> 
> -
> : send the line "unsubscribe 
> linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux