Re: [PATCH] SPI transport class and generic Domain Validation for fusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 08, 2005 at 04:46:30PM -0500, James Bottomley wrote:
> Eric,
> 
> This attached patch should do DV on both physical devices and the
> underlying devices of fusion IM assemblies (providing you apply it on
> top of the prior underlying device exposure patch), which, I believe was
> your only outstanding concern with the last generic DV patch.
> 
> There is one slight unsightly piece: the IM device still attaches to the
> transport class however all the parameters it shows actually belong to
> the underlying device at that id ... I could do with finding a way of
> persuading the SPI transport class not to attach to RAID devices.
> 
> Since this addresses all of LSI's prior concerns, may I now apply it?

 - there's a stale printk("HERE2\n"); in mptscsih_writeSDP1.
 - the #undef MPTSCSIH_ENABLE_DOMAIN_VALIDATION is probably not needed
 - the hd == NULL check in mptspi_target_alloc isn't needed
 - should the driver print a warning about too old firmware when we can't
   access page 0?
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux