Arjan, I'll resend this patch including **only** the version info updates. That's really the only important changes anyway ... Thanks. Jack -----Original Message----- From: Arjan van de Ven [mailto:arjan@xxxxxxxxxxxxx] Sent: Friday, July 22, 2005 10:53 AM To: Hammer, Jack Cc: linux-scsi@xxxxxxxxxxxxxxx Subject: Re: ServeRAID V7.12 > > > --- a/drivers/scsi/ips.c Tue Jul 19 13:15:24 2005 > +++ b/drivers/scsi/ips.c Tue Jul 19 13:12:44 2005 > @@ -133,10 +133,12 @@ > > #ifdef MODULE > static char *ips = NULL; > -module_param(ips, charp, 0); > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,25) MODULE_PARM(ips, > +"s"); #else #include <linux/moduleparam.h> #define > +MAX_BOOT_OPTIONS_SIZE 256 static char > +boot_options[MAX_BOOT_OPTIONS_SIZE]; > +module_param_string(ips, boot_options, MAX_BOOT_OPTIONS_SIZE, 0); > +#endif > #endif this looks like a major code quality regression! In fact, the outer MODULE ifdef should also go away > #ifdef MODULE > - if (ips) > - ips_setup(ips); > +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,25) > + ips = boot_options; > +#endif > + if (ips) > + ips_setup(ips); this looks like a code clutter for a 2.6 driver - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
