Ben Collins wrote:
[James Bottomley wrote]
I notice that you don't do a scsi_device_put() after
scsi_add_device(). I think this is probably the source of the
refcounting errors: scsi_add_device returns an sdev with the refcount
incremented by one, so you need to decrement the count after you've
finished with it (in your case, you do nothing with it, so just
decrement after you've checked it's not an error pointer).
Thanks. Stefan, can you test with that change? I've already put it in the
repo.
That fixes it. The error handler commits suicide when he should, and the
sbp2 module can be unloaded.
Thanks James.
--
Stefan Richter
-=====-=-=-= -=== -=-=-
http://arcgraph.de/sr/
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
