Ok, I see that the rw and ms 10byte conversions are in the scsi lib now. Thing is, these don't seem to be working for SBP2. I assume these conversions came from libata (since that's the only other user of them). Is that correct? Was the logic compared to the SBP2 conversions before being moved over to using them? Reverting this portion wont break anything, correct? Just means we have duplication of code (well, except that one works for us and the other doesn't). I'm going to revert this in my merge with Linus, but I will retain it in our tree until we can figure out what the problem is. -- Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ Subversion - http://subversion.tigris.org/ SwissDisk - http://www.swissdisk.com/ - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html