RE: [PATCH] - mptfusion - adding back the spin locks in eh handle rs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff - I didn't realize that the host-lock spin locks were removed inside
scsi mid layer scsi_error.c code.  I just applied James
scsi-misc-2.6.diff against the 2.6.12 kerne.  Just built this kernel
and tested the fusion driver, and I'm happy.  No problem, ignore yesterdays
patch.

I will have to repost the other two patch's later today; e.g. 
- change_queue_depth API
- FC transport support.

Eric


On Thursday, June 23, 2005 5:18 PM, Jeff Garzik wrote:
> Moore, Eric Dean wrote:
> > Luben
> > 
> > Ok - So you agree that completing Task management request
> > in the same context as the eh threads is the way to go, right?
> > 
> > Because that is what this LLD is doing.  Have you had
> > a chance to look at our code?
> > 
> > That previous patch submitted by Jeff(I guess) was removing 
> code which
> > enabled interrupts.  My patch was restoring it back to previous
> > working code which doesn't hang the driver.
> 
> What was broken?
> 
> MPT abort handler would release the spinlock at the beginning, and 
> reacquire it at the end, essentially reversing the spinlocks 
> in the old 
> spinlocked EH code.
> 

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux