On Thursday, June 23, 2005 1:04 PM, Luben Tuikov wrote: > On 06/23/05 14:20, Moore, Eric Dean wrote: > > The eh handlers are called with host_lock acquired, and > interrupts disabled. > > However fusion waits for completion of task managment > request. With these spin locks > > removed, the driver is going to hang within the sleep > calls. Someone recently posted > > a patch to remove them(don´t know who), and can be found > in James Bottomely scsi-misc branch. > > That was Jeff, and I thought those patches made it in already. > They are needed and are a good thing. > > Luben > Ok, explain that to me why having our driver hang is a good thing. The task managment requests to our firmware stack are done in interrupt mode, thus we have sleep and have interrupts enabled in the eh threads waiting on the commands to complete. Christoph H. requested this change about 6 months ago, asking that we remove our watchdog timers in the eh threads, in favor of this design. Eric Moore LSI Logic Corporation - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
