For the fragment: + + /* + * GetBusInfo + */ + + fib_init(fibptr); + + bus_info = (struct aac_bus_info_response *) fib_data(fibptr); + + memset(info,0,sizeof(*bus_info)); + + command = (struct aac_bus_info *)bus_info; I hate to do this to a patch that has already undergone some review, especially since this as merely cosmetic, but I noticed that the memset was on the 'info' pointer rather than the 'bus_info' pointer. One should note that the value of info is the same as bus_info, they are simply two different types originating from a void * source; there is no functional difference, the resultant code will work fine in either case. Supplementary cleanup patch (if there is such a thing): diff -u a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -671,7 +671,7 @@ bus_info = (struct aac_bus_info_response *) fib_data(fibptr); - memset(info,0,sizeof(*bus_info)); + memset(bus_info,0,sizeof(*bus_info)); command = (struct aac_bus_info *)bus_info; -- Mark Salyzyn - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
