On Fri, Jun 17, 2005 at 01:31:24PM -0500, mike.miller@xxxxxx wrote: > This patch adds pci domain info to our CCISS_GETPCIINFO ioctl. This > is to support the next generation of Itanium platforms. We had a couple > of spare bytes in the structure. Impact to existing apps should be > minimal. Please consider this patch for inclusion. > typedef struct _cciss_pci_info_struct > { > + unsigned int domain; > unsigned char bus; > unsigned char dev_fn; > __u32 board_id; Um, what? There's no way this doesn't break the ABI. You do have spare bytes in the struct, but to use them, you have to add an 'unsigned short' between dev_fn and board_id: typedef struct _cciss_pci_info_struct { unsigned char bus; unsigned char dev_fn; + unsigned int domain; __u32 board_id; } -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html