My recommendation is to use the patch I last posted, with the call to target_parent in scsi_alloc_target(). Simple and covers all bases. This would fix 2.6.12. We can then investigate better alternatives post 2.6.12 release. -- james s > -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > Sent: Friday, June 17, 2005 7:12 AM > To: Patrick Mansfield > Cc: Christoph Hellwig; Smart, James; linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [Patch] take 4: Correct issue with midlayer scsi target > allocation and transports that create the targets > > > On Tue, Jun 14, 2005 at 03:54:33PM -0700, Patrick Mansfield wrote: > > > scsi_get_host_dev is a library function for LLDDs and > does not need to > > > care about this. > > > > But if the transport is like FC or iSCSI, the eventual calls to > > scsi_alloc_sdev() will fail (for qlogic, ->slave_alloc > returns ENXIO) or > > somehow be incorrect, so why not change these? > > I'd rather see people not using it. And in case we need any caller > to use scsi_target_parent we should consolidate this. Anyway > we should > have a simple as possible patch for 2.6.12. Probably the one before > this one. > > - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
