RE: [PATCH] for Deadlock in transport_fc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> Thank you for the explanations. We tested a bit more and 
> found out, that
> one has to wait lpfc_nodev_tmo seconds between disconnecting 
> one target
> from the fabric and connecting the other.
> As this might be done quite fast in our tests, we now set 
> lpfc_nodev_tmo
> to 1, and it seems to work fine. Is there any risk with such a short
> timer?

The risk of setting this too low is that normal links may occur where
the port disappears for longer than 1 second. If so, the lpfc driver
will notify the transport of a loss of the port, which will tear down
the target and all luns. In your test case, it's what you wanted.
In otherwise normal scenarios, it may not be.  If it did occur, and
the port came back, discovery should see it, re-add the port with the
transport, kick off the scsi scan, and enumerate the target and luns
again.  Beware though- if you are not using udev, name shift may occur.

> For my understanding: what is "echo 1 > 
> sys/class/scsi_host/host1/issue_lip"?
> When we used it after not having waited for nodev_tmo, it 
> didn't cause a
> rescan (i.e., the target still had the old wwpn).

This either injects a LIP if the topology is loop, or bounces the link if
the topology is pt-2-pt. Discovery has to then kick in and complete before
changes would be seen.

> 
> BTW: at least once when we disconnected one target and 
> connected the other
> without waiting for nodev_tmo, we saw the situation, that the 
> new target was
> accessible, while sysfs still showed us the old wwpn.

We ought to track this further offline. There's more detail I'd like to
get from you to ensure there isn't an error here.

-- james s
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux