On Fri, May 27, 2005 at 12:32:07AM -0400, Jeff Garzik wrote:
SCSI EH processing already serializes things during EH, so this spinlock isn't really needed.
Removing the spinlock outright would break drivers that surround logic with spin_unlock_irq()..spin_lock_irq(), so I introduced ->unlocked_eh option.
Linus has vetoed such conditional locking in the past. However if you do it don't make it EH specific but introduce a ->concurrent flag that disables taking host_lock for ->queuecommand aswell.
Such a 'concurrent' flag violates Linus credo "do what you must, and no more." It's also silly and much too invasive.
Removing the locking from the EH routines (only), and fixing up all necessary drivers, is much more appealing.
Jeff
- : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
