On Wed, 2005-05-25 at 08:13 +0100, Christoph Hellwig wrote: > Do we really need separate functions for this? It would be so much nicer > to just have target_priv_size and device_priv_size members in the > foo_function_template. Yes, it would mean having this in all different > transport templates, but in general having this as compile-time initializer > seems a lot nicer. Well, they're not functions, they're inlines. You at least have to have an accessor function because the reserved area occurs after the transport attributes and is aligned on the pointer size. However, my first implementation was per transport class. You don't actually need the x_private_offset at all because you know the size of the transport attributes. I didn't like it because of all the duplication, but I'm willing to go back to it if there's strong feeling either way. James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
