On 05/24/05 02:21, Jens Axboe wrote: > suspend/resume is a lot more complicated than just flushing a cache, the > below will probably get you safe asleep but you will never get devices > alive again after power-up on suspend-to-ram. > > I also greatly prefer issuing a standby command to the drive after the > flush, so that we don't risk using the emergency parks of the drive. If > a drive happens to lie about wrt the flush command, it gets an extra > chance to flush the cache as it now knows that power will be gone very > soon. So I think the ->suspend/->resume hooks should belong to the LLD, > not the ULD as the ULD has no idea how to suspend all devices types. Very, very true and very, very correct! Luben - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html