Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] writes: > On Mon, May 23, 2005 at 11:36:48AM -0700, Mark Haverkamp wrote: >> > the "Adaptec Raid Controller:" doesn't belong in here. The driver build >> > data and version neither, use MODULE_VERSION instead. >> >> Using MODULE_VERSION in the snprinf doesn't seem to work: >> >> drivers/scsi/aacraid/linit.c: In function `aac_show_host_version': >> drivers/scsi/aacraid/linit.c:541: error: `MODULE_VERSION' undeclared (first use in this function) > >sorry, MODULE_VERSION is a macro similar to MODULE_LICENSE or >MODULE_AUTHOR. >You say MODULE_VERSION("something"); outside any function and you can find >the version out using modinfo and sysfs (not sure the latter is implemented >yet, but there were patches floating around) modinfo reports the binaries modules information. The sysfs version would report the actual in-memory driver information. How do we make sure the sysfs report of the MODULE_VERSION patch is driven home? :-) Sadly, we can't access the string that was placed into the .modinfo section (the name is a concatenation of the 'verison' with the line number of the MODULE_VERSION 'call') from within the driver program for use in the host_version function. -- Mark Salyzyn - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
