On Sun, 2005-05-22 at 17:54 +0100, Christoph Hellwig wrote:
> On Tue, May 17, 2005 at 01:34:57PM -0700, Mark Haverkamp wrote:
[...]
> > +static ssize_t aac_show_host_version(struct class_device *class_dev,
> > + char *buf)
> > +{
> > + int len;
> > +
> > + len = snprintf(buf, PAGE_SIZE, "Adaptec Raid Controller: %s %s\n",
> > + AAC_DRIVER_VERSION,
> > + AAC_DRIVER_BUILD_DATE);
> > + return len;
> > +}
>
> the "Adaptec Raid Controller:" doesn't belong in here. The driver build
> data and version neither, use MODULE_VERSION instead.
Using MODULE_VERSION in the snprinf doesn't seem to work:
drivers/scsi/aacraid/linit.c: In function `aac_show_host_version':
drivers/scsi/aacraid/linit.c:541: error: `MODULE_VERSION' undeclared (first use in this function)
>
> > +
> > +static ssize_t aac_show_model(struct class_device *class_dev,
> > + char *buf)
> > +{
> > + struct aac_dev *dev = (struct aac_dev*)class_to_shost(class_dev)->hostdata;
>
> No need to cast.
It looks like the cast is needed. If I remove it I get a compile
warning.
drivers/scsi/aacraid/linit.c: In function `aac_show_model':
drivers/scsi/aacraid/linit.c:548: warning: initialization from incompatible pointer type
--
Mark Haverkamp <markh@xxxxxxxx>
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
