Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] writes: >> +static ssize_t aac_show_kernel_version(struct class_device *class_dev, >> + char *buf) >> +{ >> + struct aac_dev *dev = (struct aac_dev*)class_to_shost(class_dev)->>hostdata; >> + int len, tmp; >> + >> + tmp = le32_to_cpu(dev->adapter_info.kernelrev); >> + len = snprintf(buf, PAGE_SIZE, "kernel: %d.%d-%d[%d]\n", >> + tmp >> 24, (tmp >> 16) & 0xff, tmp & 0xff, >> + le32_to_cpu(dev->adapter_info.kernelbuild)); >> + return len; >> +} >Again please remove the prefix. Also what does kernel version mean in >this context? This is the kernel running in the Firmware of the Adapter. I would be concerned about "kernel_version" confusion in the namespace of the /sys/ filesystem. Dropping the prefix is not an issue, but do we have documented naming standards for driver & firmware specific details? -- Mark Salyzyn - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
