On Mon, 2005-05-16 at 02:59 +0100, Al Viro wrote:
static int sbp2scsi_slave_configure (struct scsi_device *sdev) { blk_queue_dma_alignment(sdev->request_queue, (512 - 1)); - + sdev->use_10_for_rw = 1; + sdev->use_10_for_ms = 1; return 0; }
This looks wrong. The RBC standard only specifies the six byte commands to be mandatory ... so shouldn't this be sdev->use_10_for_ms = 0?
That's why its in sbp2-specific code...
The above code certainly applies to real-world cases, at least. Just look at the code that was removed... MS(10) handling.
Jeff
- : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
