Re: [PATCH] Sanitize PQ3 device handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 18, 2005 at 04:05:36PM +0200, Hannes Reinecke wrote:
> > If scsi_probe_and_add_lun returns SCSI_SCAN_TARGET_PRESENT sdev isn't valid at
> > this point.  You should probably default to SCSI_2 for that case.
> > 
> How so? This is exactly the behaviour I've removed. sdev is valid even
> for SCSI_SCAN_TARGET_PRESENT.
> If not please show me.

Indeed, you replaced the check at the end of scsi_probe_and_add_lun.  I don't
think it makes a lot of sense to leave around the stale scsi_dev for PQ3, though.

Doing a REPORT_LUNS for SCSI_SCAN_TARGET_PRESENT does OTOH make a lot of sense,
there's nothing in the spec against it.  So what about dropping that device
after we're done with REPORT_LUNS?

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux