Re: [PATCH 2.6.12-rc4-mm1 3/4] megaraid_sas: updating the driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +
> +		if (exception) {
> +	
> +			spin_lock( instance->host_lock );
> +			cmd->scmd->scsi_done( cmd->scmd );
> +			spin_unlock( instance->host_lock );

are you really sure you don't want to use spin_lock_irqsave() here ?

> +	unregister_chrdev( megasas_mgmt_majorno, "megaraid_sas_ioctl" );

I really don't like this idea of weird ioctl devices though...


-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux