Hello, James. On Sat, May 14, 2005 at 11:26:23AM -0400, James Bottomley wrote: > On Sat, 2005-05-14 at 22:57 +0900, Tejun Heo wrote: > > As all requests are now terminated via scsi midlayer, we don't > > need to set end_io for special reqs, remove it. > > This statement is untrue as long as the prep function can return > BLKPREP_KILL, which it still does even after your patch set, so the > scsi_wait_req_end_io() is still necessary to catch this case. BLKPREP_KILL is only used to kill illegal (unpreparable, way-off) requests. Actually, for special requests, the only tests performed are req->flags and CDB_SIZE tests. I don't think anyone does/will submit that illegal requests via scsi_wait_req(). And if so, it will be a bug. I don't feel strong against keeping the end_io routine but, if you decide to keep the routine, please consider adding a comment explaining the peculiar path the routine might be used, such that other people don't have to wander through the code. Thanks. -- tejun - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
