On Wed, May 11, 2005 at 12:40:05PM -0400, Luben Tuikov wrote: > On 05/10/05 18:58, Patrick Mansfield wrote: > > As you say, what you really want is the correct result going back to the > > user, not the result of the TUR. > > > > So save and restore the result in scsi_eh_tur, and also in scsi_eh_try_stu. > > The request sense one already saves and restores it. > > I think he even wants the stronger condition -- after the command is reclaimed > from the LLDD, just send back the result to the application client. And let > the application client decide whether they want to send TUR or something else. The TUR is part of the error recovery, and so it should be sent independent of the timed out command. I know we want to have transport specific error (or timeout) handling and recovery. But for current usage, we should return the result of the timeout to the upper level driver (and implicitly to the application). -- Patrick Mansfield - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
