>>The error handler is mainly a timeout handler, so it has to run to cancel >>the timed out command, we can't complete the timed out command back to the >>upper level until we know the HBA is no longer using it. >> >> >> >>>Consider a case that just came up. A USB CD drive causes a phase error >>>when it receives a certain READ BUFFER command (buggy firmware on the >>>drive, never mind that now). You would expect the user program to receive >> >>>from sg a host_status value indicating DID_ERROR or something of the sort. >> >>>Instead the error handler takes charge and sends out one or two TEST UNIT >>>READY commands. The status information finally received by the user >>>program is the status from the TEST UNIT READY, not from the failed READ >>>BUFFER! How's a program supposed to cope with that sort of obfuscation? >> >> >>:-( I think Alan even wants to see the QUEUEFULL status not being retried. That is, other than reclaiming the command from the LLDD, the eh code should not retry or do anything with the command, just pass it back to the user process who sent it via sg. Maybe the application client has other tricks up its sleeve on QUEUEFULL coming from the device. I think scsi generic as a passthrough, where minimal logic from SCSI Core is applied and most is left to the application client. Luben - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
