On Thu, Apr 21 2005, James Bottomley wrote: > On Thu, 2005-04-21 at 08:10 +0200, Jens Axboe wrote: > > I wondered about this action recently myself. What is the point in > > requeueing this request, only to call scsi_run_queue() -> > > blk_run_queue() -> issue same request. If the point really is to reissue > > the request immediately, I can think of many ways more efficient than > > this :-) > > Well ... that's because the logic that decides whether to plug the queue > or simply exit is in the scsi_request_fn(). That's what the comment is > about. We could abstract the check into a function, but (unless you > have any suggestions on rewording it) I thought the comment made what > was going on reasonably clear. > Looks fine, I just missed enough code context in the patch to see this. Since requeuing probably isn't all that uncommon, it may make sense to optimize this a little though. -- Jens Axboe - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
