On Thu, 21 Apr 2005, Nate Dailey wrote: > Hi, this patch changes the err_out case in st_open to decrement STp->in_use under the st_dev_arr_lock. > > I'm just basing this on looking at the code (I didn't run into an actual > problem here), but it seems like the right thing to do; st_open and > release hold the lock when adjusting in_use in other places. > I don't think it is necessary hold the lock when setting STp->in_use to zero. The problem is that the usage is not consistent in st. Either this patch should be included or the locking should be removed from st_release. I don't have any strong opinions about the best solution. Thanks for pointing out this inconsistency. -- Kai - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
