Re: The future of host_scribble

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 21, 2005 at 01:23:33AM +0100, Matthew Wilcox wrote:
> 
> In scsi_cmnd there's an element called host_scribble.  The name and the
> comment by it were sufficiently confusing that I didn't realise that this
> field is basically for the host's private data.  Any objections to something
> like this, assuming I also submit a patch that converts all the drivers?

Actually the situation about private data in scsi_cmnd is worse, there's
another private data, that's the scsi_pointer structure embedded as SCp
member.  If we're going to fix up naming we should find a way to fixup
both an have a sensible name for both embedded and out of struct private
data.  I somehow doubt it's going to happen before we drop support for
gcc 2.95 and thus can use anonymous unions :)
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux