On Sat, Apr 02, 2005 at 02:35:57PM +0900, Tejun Heo wrote: > Hello, Eric. > Hello, James. > > I've been working on new SCSI state model and was checking on > scsi_device_online() users. As the state model is going to change, I > need to audit device state usages in lldd's and I'm having difficult > time understanding why scsi_device_online() is used in mptscsih. > > In mptscsih.c, mptscsih_flush_running_cmds() uses > scsi_device_online() to determine whether or not dma-unmap data area > of active commands. This was added in the changeset 1.1371.776.1 by > Eric Moore with the comment "MPT Fusion add back FC909 support". Can > you please explain me why and how scsi_device_online() condition is > used here? I brought that issue up a while ago, but we didn't really get anywhere, see the "fix dma mapping leak in fusion" thread on linux-scsi. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html